Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix FPE issue in EigenStepper #698

Merged
merged 2 commits into from
Feb 5, 2021
Merged

fix: Fix FPE issue in EigenStepper #698

merged 2 commits into from
Feb 5, 2021

Conversation

baschlag
Copy link
Contributor

@baschlag baschlag commented Feb 5, 2021 •
edited
Loading

An FPE occurrence was reported in Athena when running the Iterative Vertex Finder, which should be fixed with this PR.

@baschlag baschlag added this to the next milestone Feb 5, 2021
@baschlag baschlag added Bug Something isn't working Component - Core Affects the Core module labels Feb 5, 2021
paulgessinger
paulgessinger approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we not fix this at some point? Was that another spot or did we not include that in master?

@baschlag
Copy link
Contributor Author

baschlag commented Feb 5, 2021

Did we not fix this at some point? Was that another spot or did we not include that in master?

The first PR tackling FPEs in Athena did apparently not include fixes in the EigenStepper. In all previous tests no issues were seen there.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #698 (8da081b) into master (4d7f1d7) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #698   +/-   ##
=======================================
  Coverage   48.99%   49.00%           
=======================================
  Files         331      331           
  Lines       16549    16549           
  Branches     7724     7723    -1     
=======================================
+ Hits         8109     8110    +1     
  Misses       3009     3009           
+ Partials     5431     5430    -1
Impacted Files Coverage Δ
Core/include/Acts/Propagator/EigenStepper.ipp 51.92% <50.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7f1d7...b6b684a. Read the comment docs.

@paulgessinger paulgessinger merged commit b0987df into acts-project:master Feb 5, 2021
asalzburger pushed a commit to asalzburger/acts that referenced this pull request Feb 8, 2021
@baschlag @asalzburger
fix: FPE: introduce std::abs for stepSize check in EigenStepper (acts…
a40ae7b 
…-project#698)

An FPE occurrence was [reported in Athena](https://its.cern.ch/jira/browse/ATLASRECTS-5989) when running the Iterative Vertex Finder, which should be fixed with this PR.
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Feb 9, 2021
@baschlag @paulgessinger
fix: FPE: introduce std::abs for stepSize check in EigenStepper (acts…
5f677d9 
…-project#698)

An FPE occurrence was [reported in Athena](https://its.cern.ch/jira/browse/ATLASRECTS-5989) when running the Iterative Vertex Finder, which should be fixed with this PR.
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Feb 10, 2021
@baschlag @paulgessinger
fix: FPE: introduce std::abs for stepSize check in EigenStepper (acts…
5f45cf0 
…-project#698)

An FPE occurrence was [reported in Athena](https://its.cern.ch/jira/browse/ATLASRECTS-5989) when running the Iterative Vertex Finder, which should be fixed with this PR.
@paulgessinger paulgessinger modified the milestones: next, v6.0.0 Mar 2, 2021
@baschlag baschlag deleted the fix_fpe_eigenstepper branch May 19, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Component - Core Affects the Core module
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@baschlag @paulgessinger