Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Aria Button on Management App #2916

Merged
merged 8 commits into from
Jul 17, 2024
Merged

React Aria Button on Management App #2916

merged 8 commits into from
Jul 17, 2024

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

@joel-jeremy joel-jeremy changed the base branch from master to react-aria-button-4 June 21, 2024 17:25
@github-actions github-actions bot changed the title React Aria Button on Management App [WIP] React Aria Button on Management App Jun 21, 2024
Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit c9df8af
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6698179e9e5f5d0008b2b451
😎 Deploy Preview https://deploy-preview-2916.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.73 MB → 4.73 MB (-120 B) -0.00%
Changeset
File Δ Size
src/components/manager/subscribe/Login.tsx 📈 +12 B (+0.24%) 4.86 kB → 4.88 kB
src/components/manager/DeleteFile.tsx 📈 +6 B (+0.14%) 4.14 kB → 4.14 kB
src/components/manager/ImportYNAB4.tsx 📈 +3 B (+0.10%) 2.97 kB → 2.98 kB
src/components/manager/ImportYNAB5.tsx 📈 +3 B (+0.10%) 2.99 kB → 3 kB
src/components/manager/ImportActual.tsx 📈 +3 B (+0.09%) 3.37 kB → 3.37 kB
src/components/manager/subscribe/ChangePassword.tsx 📈 +1 B (+0.04%) 2.24 kB → 2.24 kB
src/components/manager/subscribe/Bootstrap.tsx 📈 +1 B (+0.04%) 2.6 kB → 2.6 kB
src/components/manager/WelcomeScreen.tsx 📉 -3 B (-0.09%) 3.43 kB → 3.43 kB
src/components/manager/Import.tsx 📉 -6 B (-0.17%) 3.39 kB → 3.38 kB
src/components/manager/subscribe/Error.tsx 📉 -2 B (-0.20%) 1005 B → 1003 B
src/components/manager/ConfigServer.tsx 📉 -13 B (-0.23%) 5.58 kB → 5.57 kB
src/components/manager/BudgetList.tsx 📉 -91 B (-0.88%) 10.14 kB → 10.05 kB
src/components/manager/subscribe/ConfirmPasswordForm.tsx 📉 -34 B (-1.42%) 2.35 kB → 2.31 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 2.98 MB → 2.98 MB (-120 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/AppliedFilters.js 27.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 76.19 kB 0%
static/js/wide.js 272.81 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

@joel-jeremy joel-jeremy force-pushed the react-aria-button-5 branch 2 times, most recently from ef260f8 to 423d5f9 Compare June 21, 2024 22:15
@joel-jeremy joel-jeremy changed the base branch from react-aria-button-4 to master July 7, 2024 07:05
@MatissJanis
Copy link
Member

There's still a bunch more unnecessary aria-labels. Would you mind taking a look at those too?

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@joel-jeremy joel-jeremy merged commit 8924162 into master Jul 17, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the react-aria-button-5 branch July 17, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants