-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme and begin image restructuring #123
Conversation
✅ Deploy Preview for zingy-bonbon-b1b286 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach! A couple of comments below plus one more: how do you feel about encouraging people to use the built-in test budget for screenshots? I don’t know whether it would be consistent enough in places like the sidebar because it has some inherent randomness so maybe as an alternative you/we could make a demo budget and save it to this repo for testing purposes?
README.md
Outdated
- click the annotate icon | ||
- from the 'shape' selector, select the 'transparency' tool | ||
|
||
![](/static/img/repo/highlighting.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files intended to be viewed on GitHub should use relative paths:
![](/static/img/repo/highlighting.png) | |
![](./static/img/repo/highlighting.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are using images in the readme can these come out of the /docs/ folder altogether please if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand what you mean by "come out of the /docs/ folder altogether".
Where should images be saved that are destined for the repo readme?
This was a screenshot taken specifically for the readme and is not an image used in actual docs.
README.md
Outdated
- click the annotate icon | ||
- from the 'shape' selector, select the 'transparency' tool | ||
|
||
![](/static/img/repo/highlighting.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are using images in the readme can these come out of the /docs/ folder altogether please if possible.
Thanks both for the detailed feedback!
I was also considering this idea and agree. It would reduce friction for people to get involved if they can just import a demo budget with transactions, accounts, etc already set up. It will also create some continuity throughout the docs due to reusing the same account names / payees / etc. I can make an issue for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like this approach. Happy to merge now or wait if you still want to do more in this PR.
great. well I'm aiming to reorganise every image that's so far being used. |
hey @j-f1 . Smashed it all out now 🤓 There were a bunch of unused images leftover. I moved them into But yeah, looking cleaner now and easier to keep a track of :~) Worth double checking that 'Open Issues' is an appropriate name for the issues link in the sidebar. But if it's nothing but a thing, then I'm not worried. Just let me know if anything should be changed 👍 |
I believe |
ah oops. thought it was just the .ico and .svg. |
spotted one other mistake now too. will have another look through and re-request. |
now should be good @j-f1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Refers to #120
Added some instructions to the readme, which include personal design considerations (highlighting with the transparency box and orange/yellow colours otherwise to work better with Actual's color scheme) and a draft of communicating the structure ideas outline below.
Please contest any of it.
Also updated about the
@2x.png
scheme from #110Was just thinking to show this preliminary work to check it's in an agreeable direction or not before continuing.
The changes in this PR boil down to (and looking for feedback on):
static/img/elements/sidebar/
For point 3 there are two options I think.
3a. the images for the page at
github.io/docs/Budgeting/filters
, would be stored instatic/img/filters
3b. the images for the same page, would be stored in
static/img/budgeting
Option 3a - ie. one folder per page at
static/img/
:img
directory.Option 3b - ie. one folder per subsection at
static/img/
:Budgeting
would be in this folder)page.md
will need to be updated and images moved to another subsection, which can potentially break other linkings in pages from the same subsection that use the same images. Or the image paths stay unchanged, breaking the relationship between page position in repo structure and where the images are found.