Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IN and NOT IN #1344

Merged
merged 22 commits into from
Jun 28, 2024
Merged

Implement IN and NOT IN #1344

merged 22 commits into from
Jun 28, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented May 13, 2024

No description provided.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 97.93814% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (18e2fd6) to head (4bf3fac).

Files Patch % Lines
...engine/sparqlExpressions/RelationalExpressions.cpp 97.53% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   88.95%   88.99%   +0.04%     
==========================================
  Files         329      329              
  Lines       29090    29155      +65     
  Branches     3230     3236       +6     
==========================================
+ Hits        25877    25947      +70     
+ Misses       2060     2055       -5     
  Partials     1153     1153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hannahbast hannahbast changed the title Implement IN and NOT IN expressions Implement IN and NOT IN Jun 27, 2024
# Conflicts:
#	src/engine/sparqlExpressions/LiteralExpression.h
#	src/engine/sparqlExpressions/SparqlExpressionTypes.h
#	src/util/Views.h
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Johannes, this looks great and works fine, some minor changes left

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change left

Copy link

sonarcloud bot commented Jun 28, 2024

@hannahbast hannahbast merged commit 797f325 into ad-freiburg:master Jun 28, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants