Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code from SparqlParser #769

Merged
merged 8 commits into from
Aug 31, 2022
Merged

Remove unused code from SparqlParser #769

merged 8 commits into from
Aug 31, 2022

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented Aug 29, 2022

Remove some code in SparqlParser.cpp that is no longer required. The tests had to be adapted slightly because the ANTLR Sparql Parser process some parts later than the old SparqlParser.cpp.

@Qup42 Qup42 changed the title Sparql parser cleanup Remove unused code from SparqlParser Aug 29, 2022
joka921
joka921 reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much,
I have found two places where possible simplifications might apply for the tests of the parser.

test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
Qup42
Qup42 commented Aug 30, 2022
View reviewed changes
test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
joka921
joka921 reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice,
I have some concrete suggestions, but most of it is general discussion on how this interacts with the other testPR.

test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
test/SparqlAntlrParserTest.cpp Show resolved Hide resolved
test/SparqlAntlrParserTest.cpp Show resolved Hide resolved
test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
Qup42 and others added 2 commits August 31, 2022 14:26
@Qup42 @joka921
Update test/SparqlAntlrParserTest.cpp
38593f2 
Co-authored-by: joka921 <joka921@users.noreply.github.com>
@Qup42
Code Review
a3cfc1c
joka921
joka921 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, you found the way to get the default argument for the EQ matcher.
I will adapt that tiny suggestion, and then I'll merge it.

test/SparqlAntlrParserTest.cpp Outdated Show resolved Hide resolved
@joka921 joka921 merged commit 6fc26d0 into ad-freiburg:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joka921 joka921 joka921 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qup42 @joka921