Add fuzzer for href setter and getter #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
May 15, 2024
| std::string source = fdp.ConsumeRandomLengthString(256); | ||
| std::string base_source = fdp.ConsumeRandomLengthString(256); | ||
|
|
||
| auto out_url = ada::parse<ada::url>(source); |
There was a problem hiding this comment.
This won't work because 99.9999% of the time out_url will be false. Because the probability of the fuzzer to pass a correct URL is really-really low.
Ideally we should create a collection of tokens to be passed with the randomly generated input.
More information can be found from: https://google.github.io/oss-fuzz/advanced-topics/ideal-integration/#dictionary
For example: iajshduahfiuahsufdiasd will not work at all, but if you surround it with https:// and .com it will pass and still fuzz almost everything.
|
Closing, it'll be pushed here: #657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.