create getLEDCurrent() method #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caternuson
requested changes
Jun 22, 2023
|
|
||
| led_raw = led_current_bits.read(); | ||
|
|
||
| led_current_ma = (uint16_t)(led_raw * 2) + 4; |
There was a problem hiding this comment.
Could just return right hand side here instead of creating led_current_ma and returning that.
There was a problem hiding this comment.
Agreed. I tend to create "unnecessary" variables for the sake of being clear and documenting what the code does.
|
Looks good. Added a review comment. Were you able to test this? Good test would be to set LED current, then read back and make sure it reports back as expected. |
|
Yes, tested and working. |
caternuson
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue 25, create getLEDCurrent()