Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Le potato patch #655

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Le potato patch #655

merged 5 commits into from
Feb 23, 2023

Conversation

Iainrach
Copy link
Contributor

I'm really not sure if I've done this correctly but this is related to issue 654.

makermelissa
makermelissa requested changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for adding. You're pretty close. You should be able to keep the SPI1 pins. I added some suggested code changes to achieve this so that it should still work with your board.

src/adafruit_blinka/microcontroller/amlogic/s905x/pin.py Show resolved Hide resolved
src/adafruit_blinka/microcontroller/amlogic/s905x/pin.py Outdated Show resolved Hide resolved
Iainrach and others added 3 commits February 23, 2023 16:03
@Iainrach @makermelissa
Update src/adafruit_blinka/microcontroller/amlogic/s905x/pin.py
be3f6d6 
Co-authored-by: Melissa LeBlanc-Williams <melissa@adafruit.com>
@Iainrach @makermelissa
Update src/adafruit_blinka/microcontroller/amlogic/s905x/pin.py
2f95cc3 
Co-authored-by: Melissa LeBlanc-Williams <melissa@adafruit.com>
@makermelissa
Ran pre-commit
2fd99b6
makermelissa
makermelissa approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@makermelissa makermelissa merged commit 802e687 into adafruit:main Feb 23, 2023
@makermelissa makermelissa mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iainrach @makermelissa