Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error message and explicity add to setup #714

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

makermelissa
Copy link
Collaborator

Fixes #599.

@makermelissa makermelissa requested a review from a team September 15, 2023 02:09
@caternuson
Copy link
Contributor

Looks like there are two things here? The changes to setup.py look like they are adding Adafruit_BBIO as a dependency? That seems OK, and would hopefully eliminate the original ImportError? This is essentially fixing a missed dependency, which seems like the actual underlying issue here. (if i understand it correctly)

The changes to pin.py are OK I guess. But it's basically just capturing one exception and turning it into another and saying the same thing again? This message from original issue thread should be enough to indicate what the issue is:

ModuleNotFoundError: No module named 'Adafruit_BBIO'

It gives the module name and says it's not found. We can leave these changes to pin.py in if it seems like the extra info in the text message will help. But should the exception type be changed?

@makermelissa
Copy link
Collaborator Author

The reason I made the change to the error message is because multiple people got confused and had difficulty finding out how to fix the error, so the new message tells them how to fix it. The change to setup.py is to make it so they are less likely to run into issues in the first place.

@caternuson
Copy link
Contributor

OK. I guess the additional from error will help keep it tied to the original underlying exception.

@makermelissa makermelissa merged commit fe8a29e into adafruit:main Sep 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beaglebone Black: Import Board Fails with "No module named 'Adafruit_BBIO'"
2 participants