New Support for ODROID-M1S #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i2c0, spi and uart are not available as default values because they are provided as aliases. Signed-off-by: Steve Jeong <steve@how2flow.net>
makermelissa
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Because you added a new microcontroller, they should be also added to:
https://github.com/adafruit/Adafruit_Blinka/blob/main/src/microcontroller/__init__.py
https://github.com/adafruit/Adafruit_Blinka/blob/main/src/microcontroller/pin.py
ODROID-M1S is rk3566 SBC. Adafruit_Blinka/src/microcontroller/pin.py Line 114 in 4e29053 |
|
Request review is my mistake.. |
makermelissa
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i2c0, spi and uart are not available as default values because they are provided as aliases.