Fix pyproject.toml packages to match setup.py #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need |
|
I'm not sure. Currently we're trying to support python.3.7 and up. A quick search appears that using pyproject.toml only should be fine. Do you know if that's the case? Removing it would make maintaining things easier. |
|
Yes, websearching brings up several places that say PyPA supports pyproject.toml on python 3.7 and up. |
|
Awesome. I'll go ahead and remove it from any of the python projects that have been updated (this, Blinka, and platformdetect I believe). Looks like Blinka may need to be converted still and PlatformDetect already had setup.py removed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the new split packages were not being installed. It's because I forgot we have pyproject.toml to update now too.