Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32u with Wire end() #70

Merged
merged 4 commits into from
Nov 26, 2021
Merged

Fix 32u with Wire end() #70

merged 4 commits into from
Nov 26, 2021

Conversation

hathach
Copy link
Member

@hathach hathach commented Nov 26, 2021

  • use WIRE_HAS_END from arch AVR to detect whether wire has end(). This will work with both avr core that implement or not the wire end()
  • Update: temporarily skip end() for esp32, which only implement end() starting from 2.0.1 (currently latest), this will give time for user to update their core (will enable later on). fix error: 'class TwoWire' has no member named 'end' #69

@hathach hathach requested a review from ladyada November 26, 2021 05:55
@hathach hathach merged commit 690da23 into master Nov 26, 2021
dl9sau pushed a commit to dl9sau/TTGO-T-Beam-LoRa-APRS that referenced this pull request Nov 26, 2021
@flavio-fernandes
Copy link

  • use WIRE_HAS_END from arch AVR to detect whether wire has end(). This will work with both avr core that implement or not the wire end()

Thank you for the quick fix!!! 🙇‍♂️

@hathach hathach deleted the fix-32u branch October 19, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: 'class TwoWire' has no member named 'end'
4 participants