Fix potential first read issue #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Oct 15, 2018
adafruit_dht.py
Outdated
| @@ -138,7 +138,8 @@ def measure(self): | |||
| delay_between_readings = 0.5 | |||
| if self._dht11: | |||
| delay_between_readings = 1.0 | |||
| if time.monotonic()-self._last_called > delay_between_readings: | |||
| if (self._last_called == 0) or \ | |||
| (time.monotonic()-self._last_called > delay_between_readings): | |||
There was a problem hiding this comment.
I find the \ line wrap error prone. Instead, I use parens:
if (self._last_called == 0 or
(time.monotonic() - self._last_called) > delay_between_readings):There was a problem hiding this comment.
Done -- I also added a comment to explain why this was added.
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 24, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.2.1 from 3.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#18 from jerryneedell/jerryn_fix_pr_14 > Merge pull request adafruit/Adafruit_CircuitPython_DHT#17 from jerryneedell/jerryn_None > ignore the board module imports in .pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#8 from kattni/folder-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16
IF self._last_called == 0 then we know that no read has ever been attempted.
This eliminates the chance of a "silent" failure and a return of None without throwing a Runtime error as well.