Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont create a background bitmap if background_color is None #74

Merged
merged 2 commits into from
Jul 24, 2020
Merged

dont create a background bitmap if background_color is None #74

merged 2 commits into from
Jul 24, 2020

Conversation

FoamyGuy
Copy link
Contributor

I think this will resolve #72

@FoamyGuy FoamyGuy requested a review from a team July 23, 2020 01:19
tannewt
tannewt requested changes Jul 23, 2020
View reviewed changes
adafruit_display_text/label.py Outdated Show resolved Hide resolved
tannewt
tannewt approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit ab0158d into adafruit:master Jul 24, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 28, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@20501cf)
4987ba3 
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.2 from 3.10.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#85 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.3.0 from 2.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#29 from gphi/measure-raw-sensor-data

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.8.0 from 2.7.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#74 from FoamyGuy/no_bitmap_when_background_none
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#73 from kmatch98/anchor_params
@kmatch98 kmatch98 mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allocate a background bitmap when background_color is None
2 participants
@FoamyGuy @tannewt