Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing tile= and serpentine= down to the RGBMatrix constructor #58

Closed
jepler opened this issue Jan 26, 2021 · 1 comment · Fixed by #59
Closed

Add support for passing tile= and serpentine= down to the RGBMatrix constructor #58

jepler opened this issue Jan 26, 2021 · 1 comment · Fixed by #59

Comments

@jepler
Copy link
Member

jepler commented Jan 26, 2021

This will require some thought, since this feature is only being added in CircuitPython 6.2, and older versions would throw an error if these values are sent in.

This also affects the automatic determination of address lines (64 rows could be 4 address bits + 2 tiles, or 5 address bits + 1 tile)

@jepler
Copy link
Member Author

jepler commented Jan 28, 2021

Please make the default value for serpentine=True.

For backwards-compatibility, you can check if tile is specified as number bigger than 1; if not, use the constructor call without tile= or serpentine=.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant