Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expired Discord link #4

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Fix expired Discord link #4

merged 1 commit into from
Dec 7, 2020

Conversation

mcauser
Copy link
Contributor

@mcauser mcauser commented Dec 7, 2020

No description provided.

@dhalbert
Copy link

dhalbert commented Dec 7, 2020

This needs a pylint fix.

@mcauser mcauser mentioned this pull request Dec 7, 2020
Merged
@mcauser
Copy link
Contributor Author

mcauser commented Dec 7, 2020

@dhalbert pylint fix in: #5

makermelissa
makermelissa approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@makermelissa makermelissa merged commit 73a4e7e into adafruit:master Dec 7, 2020
@mcauser mcauser deleted the patch-1 branch December 7, 2020 23:04
@wallarug
Copy link

wallarug commented Dec 8, 2020

Hi @makermelissa,

Can you please confirm / verify that all the PRs for the new discord link are correct?

I've noted that @mcauser has put in many PR changed across the whole of GitHub for this issue.

I just want to be sure before allowing any of these changes into any of my CircuitPython Libs.

@makermelissa
Copy link
Contributor

Yes @wallarug, the link is correct. I just verified by going to the link.

@wallarug
Copy link

wallarug commented Dec 8, 2020

Ok Thanks @makermelissa!

Benefits of not being behind a school firewall 😅 is checking discord links.

@mcauser
Copy link
Contributor Author

mcauser commented Dec 8, 2020

FYI, https://adafru.it/discord 302s to https://discord.gg/5FBsBHU, which is (Scott) tannewt's invite:

Screen Shot 2020-12-08 at 1 42 18 pm

Using the https://adafru.it/discord redirector is preferred over a discord.gg/xyz link so that when it expires, admins can simply swap in a new invite url and not update a few thousand readmes and references

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcauser @dhalbert @wallarug @makermelissa