Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update board.py #288

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Update board.py #288

merged 4 commits into from
Apr 13, 2023

Conversation

mmontol
Copy link
Contributor

@mmontol mmontol commented Apr 11, 2023

Modify board_value for LubanCat1 LubanCat2

@mmontol
Update board.py
9f42d9e 
Modify  board_value  for  LubanCat1 LubanCat2
@makermelissa
Copy link
Contributor

Are the any cases where LubanCat1 or LubanCat2 might still be valid or were they never used?

@mmontol
Copy link
Contributor Author

mmontol commented Apr 12, 2023 •
edited
Loading

The model="EmbedFire LubanCat1" in the device tree has been changed to model="EmbedFire LubanCat-1", LubanCat1 or LubanCat2 are still valid.

makermelissa
makermelissa suggested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it so it works either way then.

adafruit_platformdetect/board.py Outdated Show resolved Hide resolved
adafruit_platformdetect/board.py Outdated Show resolved Hide resolved
mmontol and others added 3 commits April 13, 2023 09:18
@mmontol @makermelissa
Update adafruit_platformdetect/board.py
d354b1f 
Co-authored-by: Melissa LeBlanc-Williams <melissa@adafruit.com>
@mmontol @makermelissa
Update adafruit_platformdetect/board.py
5e8e88c 
Co-authored-by: Melissa LeBlanc-Williams <melissa@adafruit.com>
@mmontol
Update board.py
bb31782 
Fix
makermelissa
makermelissa approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@makermelissa makermelissa merged commit 54e97bb into adafruit:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmontol @makermelissa