Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vtable error #31

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Fix vtable error #31

merged 1 commit into from
Oct 25, 2019

Conversation

PowerfulCat
Copy link
Contributor

there will result a compiler error when those function is not pure virtual function.

@PowerfulCat
Fix vtable error
f83eab1 
there will result a compiler error when those function is not pure virtual function.
hathach
hathach approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@hathach hathach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird if not having pure virtual could cause the compile error. Out of curiosity, which IDE and compiler version you are using. Though, I agree it is better as pure virtual.

@hathach hathach merged commit db3b487 into adafruit:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PowerfulCat @hathach