SSID Null-Termination Workaround #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that SSIDs are null-terminated for printing.
hydroArgentum
force-pushed
the
nulltermssid-fix
branch
from
0309aba
to
6d27ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: Added a workaround for 32-character SSIDs by adding a 33-character, null-terminated array.
Addresses: If SSIDs are 32-characters in length (WL_SSID_MAX_LENGTH), networkSsid[networkItem] will not be null-terminated. When printing the SSID, the print function will iterate through the networkSsid array into subsequent networkItems until it encounters the next Null character. (In the case of networkItem=9, the print function likely goes out of bounds until it encounters the next Null character.)
Limitations: While 32-characters SSIDs are legal, this fix uses an additional 33-bytes to work around the issue.
Tested: ScanNetworks.ino compiled and ran successfully on Feather M0 Bluefruit LE and Feather nRF52840 Express with ESP32 FeatherWing.