Adafruit_MCP230xx is missing MCP23008 defines

[andig]

I believe these defines are missing from the code for MCP23008 support:

MCP23008_IODIR = 0x00
MCP23008_GPIO = 0x12    # these are not confirmed
MCP23008_GPPU = 0x0C    # these are not confirmed
MCP23008_OLAT = 0x14    # these are not confirmed

[microbuilder]

These registers exist, but they also have a second complimentary register for the 16 bit parts ... but using the A parts accomodates the 8-bit version of the chips:

MCP23008_IODIRA = 0x00

MCP23017_IODIRA = 0x00
MCP23017_IODIRB = 0x01
MCP23017_GPIOA = 0x12
MCP23017_GPIOB = 0x13
MCP23017_GPPUA = 0x0C
MCP23017_GPPUB = 0x0D
MCP23017_OLATA = 0x14
MCP23017_OLATB = 0x15

[andig]

This is all fine, but did you ever try the code? It uses loads of defines like MCP23008_GPPU which don't exists. Obviously my suggestion is just one option of fixing it. Let me know if you want a pull request.

[microbuilder]

andig:

Sorry ... you're absolutely right! I just pushed an update that uses the correct 'A' registers. Thanks for being persistent about this. :)

[andig]

No problem, but... your fix is incomplete as the consts still use the MCP23008 naming, not MCP23017.

Might as well fix line 104 as well- the . behind value must be a ,:

self.outputvalue = self._readandchangepin(MCP23008_GPIOA, pin, value. self.i2c.readU8(MCP23008_OLATA))

[microbuilder]

Andig,

Thanks, adjusted.

Unfortunately, I don't have a 23008 here (only the 17). If you wouldn't
mind doing a pull and testing this, I'd appreciate it, otherwise I can
ping someone in the NY office when they're open.

Kevin