Recent changes to Adafruit_I2C.py break BMP085 on RasPi

[MrKahuna]

Hi,

The following changes seem to break the BMP085 when running on a Raspberry Pi. If I revert these changes it works fine.

@@ -108,8 +108,7 @@
   def readU16(self, reg):
     "Reads an unsigned 16-bit value from the I2C device"
     try:
-      hibyte = self.bus.read_byte_data(self.address, reg)
-      result = (hibyte << 8) + self.bus.read_byte_data(self.address, reg+1)
+      result = self.bus.read_word_data(self.address, reg)
       if self.debug:
         print ("I2C: Device 0x%02X returned 0x%04X from reg 0x%02X" %
          (self.address, result & 0xFFFF, reg))
@@ -120,10 +119,8 @@
   def readS16(self, reg):
     "Reads a signed 16-bit value from the I2C device"
     try:
-      hibyte = self.bus.read_byte_data(self.address, reg)
-      if (hibyte > 127):
-        hibyte -= 256
-      result = (hibyte << 8) + self.bus.read_byte_data(self.address, reg+1)
+      result = self.bus.read_word_data(self.address, reg)
+      if result > 32767: result -= 65536
       if self.debug:
         print ("I2C: Device 0x%02X returned 0x%04X from reg 0x%02X" %
          (self.address, result & 0xFFFF, reg))

[tesch1]

I second this. I noticed the same thing when working on the TMP006 driver -- I think if the user wants two 8-bit reads, they should call read8(), since some hardware doesn't have byte-addressable registers.

[F481]

In the Adafruit forum you can find some discussion about that bug: http://forums.adafruit.com/viewtopic.php?f=8&t=38255
Is there a bugfix planned in the foreseeable future?

[microbuilder]

This should be fixed now ... 16-bit access is moved into the BMP085 driver:

Adafruit-Raspberry-Pi-Python-Code/Adafruit_BMP085/Adafruit_BMP085.py

Line 66 in 7e950cf

def readS16(self, register):