Skip to content
This repository was archived by the owner on Sep 30, 2019. It is now read-only.
This repository was archived by the owner on Sep 30, 2019. It is now read-only.

Bugs, indent problems and re returning. #61

@Cediddi

Description

@Cediddi

MCP230xx.py file has multiple indent problems (STILL),

Adafruit_MCP230XX.output() has two returns and if the if statements are false, can't return. (referencing before assingment)

Adafruit_MCP230XX.input() returns the "value" which may be referenced before assingment.

Adafruit_MCP230XX.pullup() has a variable called "lvalue" which does nothing and the function is not working properly.

MCP230XX_GPIO class should be in a different branch. It's just a useless proxy for now.

Whole script is not compatible PEP8 standards, nor with Zen (PEP20). It designed well but coded poorly. I may commit but have no time, This is just a warning for developers. (Especially to KTOWN who committed "Fixed indents", can't you just use regex to find \t characters and replace them with four spaces?)

"Errors should never pass silently.
Unless explicitly silenced." Zen of Python.

Regards.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions