Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs are ignored in label and bitmap_label #118

Closed
kmatch98 opened this issue Feb 11, 2021 · 5 comments
Closed

Tabs are ignored in label and bitmap_label #118

kmatch98 opened this issue Feb 11, 2021 · 5 comments

Comments

@kmatch98
Copy link
Contributor

Currently, all tabs '\n' are ignored in both label and bitmap_label.

@lesamouraipourpre
Copy link
Contributor

That could be a challenge to define what a tab is. Do you define it as a fixed number of pixels, eg 25px, or do you define it based on the width of a character, eg 8 spaces. As a programmer, I would go with 4 spaces.

Also, how would it behave if the text is not left anchored?

@jposada202020
Copy link
Contributor

Agree with lesamouraipourpre, at the end of the day the 4 spaces will get translated to pixels in the library according to the Font used

@jposada202020
Copy link
Contributor

@kmatch98 @FoamyGuy if you are not currently wrking at this I can take a look tonight. Let me know. :)

@FoamyGuy
Copy link
Contributor

@jposada202020 I'd say go for it. Thank you! I'm going to test out the bitmap_label alignment PR next when I get back to it. This was a bit lower down the list for me, so am happy to have you take it on if you are willing to.

@FoamyGuy
Copy link
Contributor

resolved by #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants