Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor KeyboardLayoutUS to allow other layouts without duplicating code #53

Closed
dhalbert opened this issue Aug 19, 2020 · 2 comments
Closed

Refactor KeyboardLayoutUS to allow other layouts without duplicating code #53

dhalbert opened this issue Aug 19, 2020 · 2 comments
Labels
enhancement

Comments

@dhalbert
Copy link
Collaborator

Factor out the common part of KeyboardLayoutUS into a common superclass, so that someone could add another keyboard layout just by specifying the ASCII (or Unicode?) to keycode table, and sharing the rest of the code. See #46 for the initial motivation for this.
@dhalbert dhalbert mentioned this issue Nov 4, 2020
Closed
@AngainorDev
Copy link

First attempt here #61
Comments are welcome.

@dhalbert
Copy link
Collaborator Author

Fixed by #84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhalbert @evaherrada @AngainorDev