Finish digitalio and pin use tracking for ESP32S2 #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
added
enhancement
circuitpython api
espressif
dhalbert
requested changes
May 20, 2020
|
@dhalbert I fixed the other builds. Please take another look. |
|
The new |
d-c-d
reviewed
May 21, 2020
| #include "esp-idf/components/driver/include/driver/gpio.h" | ||
| #include "esp-idf/components/soc/include/hal/gpio_hal.h" | ||
|
|
||
| STATIC uint32_t never_reset_pins[2]; |
There was a problem hiding this comment.
It might be nice :-) to just say that these magic number [2] and 32 are just there to create a set or bitmap.
Since it is static ( to this file ) it's probably O.K. to use the idioms/pattern to create a 64-bit map -
( how do others do this in an abstract yet efficient way )
dhalbert
reviewed
May 26, 2020
|
@dhalbert Please take another look. CI is green. |
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
May 28, 2020
…uit#2931 from tannewt/esp32s2_digitalio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.