Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off terminalio for ja and ko #3295

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 18, 2020

The font is missing many characters and the build needs the space. This frees 6k or so in M0 builds with displayio enabled.
We can optimize font storage when we get a good font.

The serial output will work as usual.

The font is missing many characters and the build needs the space.
We can optimize font storage when we get a good font.

The serial output will work as usual.
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scott and I discussed on Discord that this change means any program that uses terminalio, approximately 32 files in the Adafriut Learning Systems Guides git repo, will stop working on ja and ko translated versions while continuing to work as written for other translations.

Those programs could hypothetically be modified to use a bitmap font read from flash, if there is enough RAM memory to hold the font. This is likely to be feasible for all but the most resource constrained builds, such as Circuit Playground Express Displayio, but I didn't do any specific testing in this area.

@tannewt
Copy link
Member Author

tannewt commented Aug 18, 2020

Thanks! This will enable us to do languages we don't know how to layout too like Hebrew and Arabic. Mandarin should be doable too.

@tannewt tannewt merged commit 24ca5c0 into adafruit:main Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants