-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32-S2: Remove calloc in AnalogIn #3810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other changes look great. I just am suggesting reducing NO_OF_SAMPLES
to speed things up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[no testing performed, but checked that Dan's earlier requested change was incorporated]
Looks like this needs manual attention due to translation changes on the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Yes, just do a merge from upstream, try make check-translate
and if that complains , a make translate
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Can merge if builds are fine.
My implementation of the ADC in AnalogIn brought in a calloc from the example code in the IDF that isn't necessary and may have been causing memory corruption. Removing it resolves #3809 on my Saola 1 (Wroom).