Fix ssl.SSLSocket bind() error checking #8962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-ssl sockets now return size_t error numbers, not bool. Fixes micropython#8947
anecdata
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Yes, that fixes ESP32-S3 HTTPS server.
Pico W and ESP32-S2 are back to the MemoryError, should probably open a separate issue for that. When it happens on ESP32-S2 (QT Py; N4R2), gc.mem_free() is 2001968 and espidf.heap_caps_get_largest_free_block() is 1933312.
Neither of these metrics capture the internal memory free. SSL only uses internal memory so secrets aren't on external memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-ssl sockets now return size_t error numbers, not bool.
Fixes #8947
@anecdata or @michalpokusa please test this.