Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logger template strs #37

Closed
wants to merge 1 commit into from

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Aug 2, 2020

This changes the template strings going into logger.info() and other level functions to use %s instead of {} this resolves the issue noted in #36

If I've missed something obvious that I just need to update to get this working then sorry for the confusion, let me know and we can close this.

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Aug 2, 2020

I see pylint is upset with all of those changes so I suspect something within my environment is wonky I will close this and try to get it straightened out locally.

@FoamyGuy FoamyGuy closed this Aug 2, 2020
@rosterloh
Copy link

I've had the same issue as this for a while and your PR fixes it for me.

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Aug 3, 2020

Thank you for reporting that @rosterloh. I try to look into it further this week. I had convinced myself it was likely an issue specific to my environment, so knowing it's affecting others is very helpful. I'll post here with whatever information I find if it's just something that needs to be updated. Or if we come to the conclusion this is a widespread issue we can re-open this PR and get some discussion about what to do about the pylint errors that CI found.

markus-wolf pushed a commit to markus-wolf/circup that referenced this pull request Oct 10, 2020
- Makefile for BlackFormat errors,
- logger. formatting (see issue adafruit#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants