Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change matrixportal to s3 type #318

Merged
merged 2 commits into from
May 19, 2023
Merged

change matrixportal to s3 type #318

merged 2 commits into from
May 19, 2023

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented May 18, 2023

8 MB flash. 2 MB PSRAM

@ladyada ladyada requested a review from hathach May 18, 2023 18:45
lyusupov
lyusupov suggested changes May 18, 2023
View reviewed changes
Copy link
Contributor

@lyusupov lyusupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S3 boards are located in a separate list:

        # ----------------------
        # S3 Alphabetical order
        # ----------------------

hathach
hathach approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great, I did move the board entry in build ci to S3 list

@hathach hathach merged commit a70bd87 into master May 19, 2023
180 checks passed
@hathach hathach deleted the matrix_s3 branch May 19, 2023 08:24
@hathach
Copy link
Member

hathach commented May 19, 2023

S3 boards are located in a separate list:

        # ----------------------
        # S3 Alphabetical order
        # ----------------------

thank you for spotting the issue, just fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyusupov lyusupov lyusupov requested changes

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ladyada @hathach @lyusupov