Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore argument, update actions #35

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

tekktrik
Copy link
Member

  • Adds ignore argument for ignoring specific bundles
  • Updates actions to use Node 20
  • Stops dumping the GitHub context, which I believe I read somewhere wasn't advised

@jepler
Copy link
Member

jepler commented Feb 12, 2024

What is the motivation for the change? I think I missed seeing context.

Does the release-gh step need the same treatment?

@tekktrik
Copy link
Member Author

No, this actually brings that functionality already in the release-gh action to the build action. The motivation is issues like adafruit/Adafruit_CircuitPython_Typing#36.

@jepler
Copy link
Member

jepler commented Feb 13, 2024

Thanks for the clarification!

jepler
jepler previously approved these changes Feb 13, 2024
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but don't know how to test

.github/workflows/build.yml Show resolved Hide resolved
build/action.yml Show resolved Hide resolved
build/action.yml Show resolved Hide resolved
release-gh/action.yml Show resolved Hide resolved
release-gh/action.yml Show resolved Hide resolved
release-pypi/action.yml Show resolved Hide resolved
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's try it!

@dhalbert dhalbert merged commit 04ef714 into adafruit:main Feb 13, 2024
1 check passed
@tekktrik tekktrik deleted the dev/update branch February 13, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants