Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to react 18 #76

Merged
merged 4 commits into from
Dec 8, 2023
Merged

feat: upgrade to react 18 #76

merged 4 commits into from
Dec 8, 2023

Conversation

adamalston
Copy link
Owner

The following change was made to address the breaking changes around expect in Jest v6: https://github.com/testing-library/jest-dom/releases/tag/v6.0.0

- import '@testing-library/jest-dom/extend-expect';
+ import '@testing-library/jest-dom';

Commit with functionality to fail tests if errors are logged to the console: d4cdc9a
Build: https://github.com/adamalston/v2/actions/runs/7122849763

The next commit with test fixes: 5cf1025
Build: https://github.com/adamalston/v2/actions/runs/7122888984


Closes #36

@adamalston adamalston merged commit d9066e4 into main Dec 8, 2023
4 checks passed
@adamalston adamalston deleted the 36-react branch December 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to React 18
1 participant