Added Django 4.2+ fixer for “Set” assert methods
#253
Conversation
| @fixer.register(ast.Attribute) | ||
| def visit_Attribute( | ||
| state: State, | ||
| node: ast.Attribute, | ||
| parents: list[ast.AST], | ||
| ) -> Iterable[tuple[Offset, TokenFunc]]: | ||
| if ( | ||
| (name := node.attr) in NAMES | ||
| and isinstance(node.value, ast.Name) | ||
| and node.value.id == "self" | ||
| ): | ||
| yield ast_start_offset(node), partial( | ||
| find_and_replace_name, name=name, new=NAMES[name] | ||
| ) |
There was a problem hiding this comment.
can we instead check for ast.Call nodes that have an ast.Attribute as their func? This would be slightly more precise, which is good for avoiding false positives.
There was a problem hiding this comment.
@adamchainz I changed my code according to your suggestion, see 0bc330e. Do you think it is okay now?
There was a problem hiding this comment.
Yeah looks good! Now we just need to wait for the Django 4.2 RC1.
We'll also need to add 4.2 as an allowed target version, if you want to add that in this PR:
django-upgrade/src/django_upgrade/main.py
Lines 26 to 44 in 4dba611
Done in 3ba65c4. |
|
Great, now we play the waiting game. |
adamchainz
force-pushed
the
ticket_33990
branch
from
3ba65c4
to
3ef8bd7
Compare
|
I said "RC" but Django 4.2 alpha 1 is out, and that's a good time to merge and release I think. People can start their test branches and run django-upgrade to clear this deprecation warning. |
adamchainz
changed the title
assertFormsetError and assertQuerysetEqual.assert methods
Fixes #252.