Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BWIPP postscript templates #499

Merged
merged 9 commits into from
Aug 2, 2023
Merged

Use BWIPP postscript templates #499

merged 9 commits into from
Aug 2, 2023

Conversation

adamchainz
Copy link
Owner

Following #496 (comment)

This isn't quite functinoal, the images are weirdly cropped

ean13

@adamchainz adamchainz marked this pull request as ready for review August 1, 2023 14:01
@adamchainz
Copy link
Owner Author

I fixed the cropping by dividing the translate x/y values by 2.

ean13

@terryburton perhaps that needs updating in https://github.com/bwipp/postscriptbarcode/wiki/Developing-a-Frontend-to-BWIPP#generating-cropped-images-via-eps ? This change makes treepoem follow that process pretty closely, apart from this divide-by-2, and using %%HiResBoundingBox.

@terryburton
Copy link
Contributor

I fixed the cropping by dividing the translate x/y values by 2.

I assume this is a result of scaling by 2 in your processing? So that's fine.

If at any point you export the EPS then you'll need to include the BoundingBox for DSC conformance purposes. It can just be floor/ceiling of the HiResBoundingBox values (maximising the enclosure).

@adamchainz
Copy link
Owner Author

I assume this is a result of scaling by 2 in your processing? So that's fine.

Ah, yes. Had a little bug there with different scale values, fixed by moving the scale out of postscript.

If at any point you export the EPS then you'll need to include the BoundingBox for DSC conformance purposes. It can just be floor/ceiling of the HiResBoundingBox values (maximising the enclosure).

Thanks, although we don't export the EPS, I'll add that now just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants