Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow blacklisted certificates (or keys) to ever be whitelisted #166

Open
adamdecaf opened this issue Feb 23, 2018 · 0 comments
Open

Don't allow blacklisted certificates (or keys) to ever be whitelisted #166

adamdecaf opened this issue Feb 23, 2018 · 0 comments
Assignees
@adamdecaf
Labels
bug
Milestone
0.3.0

Comments

@adamdecaf
Copy link
Owner

adamdecaf commented Feb 23, 2018 •
edited
Loading

There are a bunch of certificates which are blacklistd from major products. We need to never allow these through.

Chromium has a good list, but I'd like to not directly implement that. Perhaps go generate a file?

https://chromium.googlesource.com/chromium/src/+/master/net/data/ssl/

To support checking public/private keys we'll need to expand whitelist.Whitelist.
@adamdecaf adamdecaf added the bug label Feb 23, 2018
@adamdecaf adamdecaf added this to the 0.2.0 milestone Feb 23, 2018
@adamdecaf adamdecaf self-assigned this Feb 23, 2018
@adamdecaf adamdecaf mentioned this issue Feb 25, 2018
Closed
adamdecaf added a commit that referenced this issue Feb 25, 2018
@adamdecaf
pkg/whitelist: add explicit blacklist
2f50942 
Start off using Chromiums certificate blacklist for our own blacklist.

Fixes: #166
@adamdecaf adamdecaf mentioned this issue Feb 25, 2018
Merged
@adamdecaf adamdecaf changed the title Don't allow blacklisted certificates to ever be whitelisted Don't allow blacklisted certificates (or keys) to ever be whitelisted Feb 26, 2018
@adamdecaf adamdecaf reopened this Feb 26, 2018
@adamdecaf adamdecaf modified the milestones: 0.2.0, 0.3.0 Mar 1, 2018
This was referenced Mar 3, 2018
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamdecaf adamdecaf

Labels
bug
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@adamdecaf