Feature/render perf #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 13, 2017 16:15
- Remove the computed suites property - Add new filteredSuites observable array - Add updateFilteredSuites method
adamgruber
force-pushed
the
feature/render-perf
branch
from
54e34f5
to
1cb93f9
Compare
adamgruber
added a commit
that referenced
this pull request
Nov 30, 2017
* Feature/trim data (#43) * types: remove properties to match new trim data structure * components: derive properties from update suite data structure * lib: nicely stringify json data for saving to file * Feature/flexbox (#46) * nav menu: update to use flexbox * suite: update to use flexbox * test: update to use flexbox * navbar/report: use flexbox, remove unnecessary width props * quick-summary: update to use flexbox * store: remove unused props * update tests * Fix lint (#49) * Fix ESLint violations * Fix stylelint deprecation warning * Feature/perf (#51) * Duration: extend from PureComponent * Icon: convert to class and extend from PureComponent * Test: extend from PureComponent / only render body when in expanded state * Suite: convert to class / implement shouldComponentUpdate * eslint: update react rules for PureComponents * enable transform-react-constant-elements for production * remove unnecessary looping and lodash dependency from reportStore * Feature/functional tests (#52) * add functional tests * remove babel-runtime from functional tests * add info about development * Feature/improve options handling (#59) * export yargs options directly * Add saveJson option * Replace getBaseConfig method with getMergedOptions This incorporates options handling which was previously part of the reporter. * Update tests * Feature/react16 (#62) * Update react/enzyme deps * Simplify test scripts * Configure adapter for Enzyme * Update failing tests * Feature/loader (#54) * 2.2.2 [ci skip] * Add ReportBody and Loader components * Add isLoading prop and toggleIsLoading method to store * Wire up new ReportBody component * Fix broken test * Feature/html option (#63) * options: add saveHtml * lib: implement saveHtml option * Feature/long text (#67) * Add test case for long suite/test title * Fix CSS issue with test icon and long test title * Fix test lint * Feature/render perf (#64) * Separate Loader into its own component * Loader: make an observer of reportStore.isLoading * Replace computed suites property with observable filteredSuites - Remove the computed suites property - Add new filteredSuites observable array - Add updateFilteredSuites method * ReportBody: remove loader; add reaction function; call updateFilteredSuites on mount * Report: add Loader component * Update deps (#68) * Update webpack and loader deps * Add string replace loader and add VERSION property to store * Update postcss plugins and fix style calculations * Update stylelint deps and rules * Update deps * Update cross-env and fix npm scripts * Update test deps * Eslint: Update deps and fix new lint issues * Update normalize.css and remove opinionate.css * jsdom: bump minor version * Footer version (#69) * Footer: display package version * Bump version to 3.0.0 * Update documentation (#70) * changelog: change links from releases to compare * Update README * changelog: update with release notes for 3.0 * Create global reference to store as marge (#71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way rendering suites is handled. Instead of observing a computed property in the store, the
ReportBodynow observes an array that is updated as a side effect of filtering. This accomplishes two things: