Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to inline external dependencies? #26

Closed
glenjamin opened this issue Jan 18, 2016 · 5 comments
Closed

option to inline external dependencies? #26

glenjamin opened this issue Jan 18, 2016 · 5 comments

Comments

@glenjamin
Copy link

Hello!

This report looks ace, but I'd quite like a way to bundle everything into a single file - rather than having to zip the report up to move it around.

Is that something you'd be open to exposing as an option?

I can probably provide a PR if you're on board with the idea.

@adamgruber
Copy link
Owner

It's not a bad idea if you really need to keep everything to one file. Inlining the JS/CSS shouldn't pose too much of an issue. The fonts would need to be converted to base64 and then included directly into the CSS. The resulting all-in-one file might be pretty big. If you want to work up a PR I'll definitely take a look.

@adamgruber
Copy link
Owner

@glenjamin I had some time today to look into this. This PR should do what you need: #27

@adamgruber adamgruber mentioned this issue Jan 19, 2016
@mikeerickson
Copy link

@adamgruber Just curious, was this implemented? I looked at the latest build readme and don't see any mention of this capability? If so, how to enable it, think this could fix my issue as well

@mikeerickson
Copy link

@adamgruber forget the above, I have found the appropriate property!

@adamgruber
Copy link
Owner

Let me know if it works for you

On Tue, Jan 19, 2016 at 10:16 PM Mike Erickson notifications@github.com
wrote:

@adamgruber https://github.com/adamgruber forget the above, I have
found the appropriate property!


Reply to this email directly or view it on GitHub
#26 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants