Proposal: Download file

[ahmadibrahim-c]

It will be great if you can provide a way to download file from a route to be something like that

$.download('path/to/file', 'file name', options)

[oscarr-reyes]

There is an example on how to recieve files from a request in the webpage. Although it would be nice as a separated module feature

[ahmadibrahim-c]

Hey @Nosthertus , can you give me a link to that example?

[oscarr-reyes]

Sure. You can see it in http://dietjs.com/tutorials/router#middleware

formidable is used to parse multipart/form-data which is blob type and gather all the files from the submit

[ahmadibrahim-c]

As far as I understand this shows how to upload file, what I'm looking for is a way for a user to download file when he opens a link, like when he opens a link lilke this https://uploadsite.com/download/12341234 he can then download the file

[oscarr-reyes]

I was thinking to make that feature for the module i made diet-static-stream but i have gotten pretty busy.. for the moment you would have to read the file and send it in the response.

I have made an example about sending files to the client which could be helpful for you in this comment

[ahmadibrahim-c]

Thank you so much!!

[adamhalasz]

@ahmadibrahim-c $.download() actually sounds cool 👍 will add it soon

[adamhalasz]

As of v0.14.0 you can use $.download(path, filename) as such:

// Register a route that downloads the /image.png as diet_logo.png
app.get('/', function($){
    $.download('./image.png', 'diet_logo.png')
})

For reference check out the simple Download Example:
https://github.com/adamhalasz/diet/tree/master/examples/download

[oscarr-reyes]

@adamhalasz does this set any special headers to the response?, also.. does this have support for auto mime-type detection?

[adamhalasz]

@Nosthertus Yes it sets the content-disposition header. Yes it does detect the mime type since it is using $.sendFile which uses the mime.lookup method from the mime module.

[oscarr-reyes]

@adamhalasz are the headers set after or before calling the download method?.. i ask because there are cases where custom content-type is to be set with a different value which might not exist in mime module

[adamhalasz]

@Nosthertus The content-type header is set in $.sendFile which is called within the $.download method. You can take a look:
https://github.com/adamhalasz/diet/blob/master/controllers/protocols/http/signal.js#L65

[ahmadibrahim-c]

Thanks man! I really needed that.