Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the main bundle by default #3

Closed
wants to merge 1 commit into from

Conversation

arminelec
Copy link

The bundle id was hardcoded. However, other projects that are not using CocoaPods, have to use their own bundle id.

@adamhartford
Copy link
Owner

That will cause problems for Carthage (using a SwiftR framework). I think we need a change to determine:

  1. CocoaPods
  2. Framework
  3. Source code

Maybe something like this:

#if COCOAPODS
        let bundle = NSBundle(identifier: "org.cocoapods.SwiftR")!
#elseif SWIFTR_FRAMEWORK
        let bundle = NSBundle(identifier: "com.adamhartford.SwiftR")!
#else
        let bundle = NSBundle.mainBundle()
#endif

@arminelec
Copy link
Author

I have not used Carthage, but this change works for me! :)

@adamhartford
Copy link
Owner

Great! This change is in commit f53ba13 and release v0.4.0. Thanks for raising the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants