Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 562 #145

Closed
wants to merge 40 commits into from
Closed

Fix 562 #145

wants to merge 40 commits into from

Conversation

moregan
Copy link
Collaborator

@moregan moregan commented Dec 5, 2014

Several changes that make tests pass on my perlbrewed 5.6.2.

guillaumeaubert and others added 30 commits November 11, 2014 22:13
@guillaumeaubert @wchristian
Add tests for PPI::Token::HereDoc.
443f21d 
Conflicts:
	Makefile.PL
@guillaumeaubert @wchristian
Fix parsing heredocs without a trailing newline.
e46845c
@wchristian
little bit of a readability improment in PPI::Token::HereDoc
1bae7c9
@wchristian
assume * after } is an operator, not a cast
b81d157 
fixes Perl-Critic#94
@moregan @wchristian
Make the lexer recognize the implied end of a package statement that …
2bc2fc4 
…includes a block
@moregan @wchristian
Issue Perl-Critic#75 Prevent package names from being parsed as opera…
e0c7a56 
…tors, etc.
@moregan @wchristian
Issue Perl-Critic#76 Prevent package names like v10 from being versio…
b95ecd9 
…n strings
@moregan @wchristian
Issue Perl-Critic#65 Prevent sub names like v10 from being version st…
207c24b 
…rings
@moregan @wchristian
Prevent 'use' and 'no' package names from being parsed as operators
e4640bb
@moregan @wchristian
prevent left side of fat comma parsing as operator
512c2ab
@moregan @wchristian
unit test all PPI::Statement::Sub methods
8c66b71 
Conflicts:
	t/ppi_statement_sub.t
@wchristian
allow Token::Whitespace to throw useful error on unexpected input
deefad0 
fixes Perl-Critic#10
@moregan @wchristian
tabify
0d016ce
@moregan @wchristian
more test coverage and comments
136b2cd
@moregan @wchristian
fix GitHub Perl-Critic#122: "x64" being parsed as x operator plus number
4e72b4f 
fixes Perl-Critic#122
fixes Perl-Critic#123
@moregan @wchristian
PPI::Test::pragmas for test files instead of boilerplate
6514873 
Conflicts:
	t/ppi_statement_package.t
	t/ppi_statement_sub.t
	t/ppi_token_operator.t
@moregan @wchristian
t::lib::PPI::Test::pragmas for a release test
8b06afb
@moregan @wchristian
typo fixes
2ae0eae
@moregan @wchristian
test refactoring and coverage
b034573
@moregan @wchristian
unescape results from PPI::Token::QuoteLike::Words::literal
fb8f80e 
fixes Perl-Critic#124
fixes Perl-Critic#127
@moregan @wchristian
use xdigit character class -- fix Perl-Critic#100
a212df0
@moregan
Remove references to CVS, SVN, and SourceForge.
5931cf6
@moregan
Fix repeated word in documentation
6ad126c
@moregan
Fix module spelling in documentation
887914b
@moregan
Note that PPI::Token::Quote::Double::simplify does
815ebf8 
not require that the caller call flush_locations
on the document.
@karenetheridge @wchristian
fix typo in documentation
5a790f7
@moregan @wchristian
split up the old t::lib::PPI
6483fd5
@moregan @wchristian
factor out the pause() function
3b8f7f3
@moregan @wchristian
factor out find_files()
4588c4c
@moregan @wchristian
factor out quotable()
8ec0034
@moregan moregan mentioned this pull request Jan 19, 2015
Closed
@jmaslak
Copy link
Contributor

jmaslak commented Jul 19, 2015

I made some changes to the code used by the 07-token.t test in #173 which I believe actually fixes the root cause of 1_0E1_0 not being handled right - I don't have a 5.6.2 machine to verify it, but I believe it's a case where a 32 bit Perl with longdouble support is causing problems - see #173 . That would also explain why there is at least one passed test on 5.6.2 (a 64 bit Perl): http://fast-matrix.cpantesters.org/?dist=PPI%201.220;os=linux;perl=5.6.2;reports=1

@wchristian
Copy link
Member

Thanks, this has been cherry-picked and released. :)

@wchristian wchristian closed this May 14, 2017
@moregan moregan deleted the fix-562 branch January 22, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moregan @jmaslak @wchristian @guillaumeaubert @karenetheridge