Refactor DokkatooKotlinAdapter, fix AndroidJVM target, add DokkatooAndroidAdapter #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tidy up the complication/source set details extractors - move extractors into specific companion objects - update logic to better match DGP code
… builder utility classes
…abled dynamically based on the analysis platform
…date the configuration-files-fetch logic to fetch JAVA_RUNTIME files
…to result in the wrong Java version in the KotlinMultiplatformExample test...?
aSemy
force-pushed
the
fix/refactor_kotlin_adapter
branch
from
e9b8972
to
05c3942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes several issues discovered while investigating #57
KotlinPlatformTarget.key- replaced with an internal val that better matches DGP current display name of targets.DokkatooKotlinAdapterto better match existing DGP codeDokkatooAndroidAdapterto automatically enable the Android documentation linkfinalizeCoroutinesfails, as the method isn't present)getName()ofDokkaSourceSetIdSpec- it now includes the source set nameandroid.jarvia theandroidApisconfigurationJAVA_RUNTIMEfiles via configurations, because otherwise the Android-based configurations don't seem to work.