Skip to content
This repository has been archived by the owner on Mar 1, 2021. It is now read-only.

fix build and tests #17

Merged
merged 18 commits into from
Nov 21, 2014
Merged

fix build and tests #17

merged 18 commits into from
Nov 21, 2014

Conversation

adamralph
Copy link
Owner

fixes #16
fixes #15

@adamralph
Copy link
Owner Author

@aarondandy I'll keep adding refactoring commits until you merge, so it makes sense if you review this commit by commit. Each is isolated and makes sense on it's own.

@adamralph
Copy link
Owner Author

OK, that's my lot for today. I'm off to bed - have fun with my monster PR 😜

@aarondandy
Copy link
Contributor

I have been following it incrementally today so it won't be too big. I'll give it another complete look and make sure the tests and dog*.bat still work for me.

@adamralph
Copy link
Owner Author

I don't think dog.bat will work anymore but we can also look at fixing that
separately. It's probably easiest if I push an alpha to nuget.org in the
morning so we can add it back to the top level packages.config and
baufile.csx itself can start dogfooding it. The local dogfooding script
should then work again since it will have the folder structure in place to
drop in the locally built nupkg.
On 20 Nov 2014 23:31, "Aaron Dandy" notifications@github.com wrote:

I have been following it incrementally today so it won't be too big. I'll
give it another complete look and make sure the tests and dog*.bat still
work for me.


Reply to this email directly or view it on GitHub
#17 (comment).

aarondandy added a commit that referenced this pull request Nov 21, 2014
@aarondandy aarondandy merged commit 1be9715 into adamralph:dev Nov 21, 2014
@aarondandy
Copy link
Contributor

Works great. I was able to get bau.bat and dog.debug.bat to work temporarily, they should be fine once the first package is pushed. For NCrunch I just had it copy NuGet.exe and NuGet.CommandLine.*.nupkg to the correct locations into the test folders.

@adamralph adamralph deleted the ralphactor branch November 21, 2014 06:00
@adamralph
Copy link
Owner Author

What did you have to do to get bau.bat working? That works fine for me as is.

@aarondandy
Copy link
Contributor

Maybe that one worked, I forget.


From: Adam Ralphmailto:notifications@github.com
Sent: ‎11/‎20/‎2014 23:05
To: bau-build/bau-nugetmailto:bau-nuget@noreply.github.com
Cc: Aaron Dandymailto:aaron.dandy@live.com
Subject: Re: [bau-nuget] fix build and tests (#17)

What did you have to do to get bau.bat working? That works fine for me as is.


Reply to this email directly or view it on GitHub:
#17 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Bau build Remove dependency on specific scriptcs configuration for tests to pass
2 participants