Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading a non-existent command throws an InvalidOperationException #253

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

adamralph
Copy link
Owner

@adamralph adamralph commented Dec 5, 2020

Reading a non-existent command throws an InvalidOperationException, instead of a Win32Exception, as with running a command.

Breaking, since a different exception is now thrown in this scenario.

@adamralph adamralph added bug Something isn't working breaking This change could break current consumers labels Dec 5, 2020
@adamralph adamralph force-pushed the reading-non-existent-commands branch from fd8136d to c9435d1 Compare December 5, 2020 18:27
@adamralph adamralph added this to the 7.0.0 milestone Dec 5, 2020
@adamralph adamralph merged commit cbc6bbc into master Dec 5, 2020
@adamralph adamralph deleted the reading-non-existent-commands branch December 5, 2020 18:32
@adamralph adamralph mentioned this pull request Dec 5, 2020
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change could break current consumers bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant