-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/reuse predictions #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sumes a prediction, or the stroke is ended. this commit nearly works, but next commit will add a test case where a stroke ends with more predicted points than could be consumed during the stroke.
…ashing in the app
…expecting an update.
…point needed to be removed within a cycle
…ther or polyline stream
…olyline/bezier output
…will trigger updated point indexes of those removed points, and smoothers should ignore those.
… no longer needed because the input polyline has fewer points than its last version
…ted during the same update
…lement and also re-appending that element when it shouldn't have, which was causing an element to get duplicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of issues, most of all how predicted points are handled.
estimationUpdateIndex
. however, from the documentation this seems to be incorrect, and each predicted point should be handled on its own. all predicted points are appended to the path and only removed when a new concrete point has been added to the path. if other points are only updated, the predictions are maintained..ended
event has been sent