Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorboard Strategy. #789

Merged
merged 19 commits into from
Aug 18, 2021
Merged

Tensorboard Strategy. #789

merged 19 commits into from
Aug 18, 2021

Conversation

MakGulati
Copy link
Contributor

For incorporating tensorboard, we need to finalize two things:

  • should i put in strategy folder so that i can directly include weighted_loss_avg function from .aggregate?

  • regarding the indexing of round: 0-indexed or 1-indexed and notion of -1 round

Thank you.

@MakGulati MakGulati marked this pull request as ready for review July 26, 2021 09:00
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared some thoughts. Looking forward to your answer.

examples/simulation/TensorBoardStrategy.py Outdated Show resolved Hide resolved
examples/simulation/TensorBoardStrategy.py Outdated Show resolved Hide resolved
examples/simulation/TensorBoardStrategy.py Outdated Show resolved Hide resolved
Merge branch 'main' of github.com:MakGulati/flower into main
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MakGulati thank you for the PR. We decided to merge this now. We will iterate over the API in the upcoming weeks and keep you updated on Slack :) Thank you for starting this!

@tanertopal tanertopal merged commit 103127e into adap:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants