-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensorboard Strategy. #789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared some thoughts. Looking forward to your answer.
Merge branch 'main' of github.com:MakGulati/flower into main
Few improvements
small typo. Co-authored-by: Taner Topal <taner@adap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MakGulati thank you for the PR. We decided to merge this now. We will iterate over the API in the upcoming weeks and keep you updated on Slack :) Thank you for starting this!
For incorporating tensorboard, we need to finalize two things:
should i put in strategy folder so that i can directly include weighted_loss_avg function from .aggregate?
regarding the indexing of round: 0-indexed or 1-indexed and notion of -1 round
Thank you.