Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deprecated jax type #175

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Change deprecated jax type #175

merged 2 commits into from
Feb 13, 2024

Conversation

LisaCoiffard
Copy link
Collaborator

@LisaCoiffard LisaCoiffard commented Feb 12, 2024 •
edited
Loading

Related issues: N/A

Fix a bug in types.py script, jax.random.KeyArray is deprecated in JAX and should be replaced by jax.Array.

Checks

  • a clear description of the PR has been added
  • sufficient tests have been written
  • relevant section added to the documentation
  • example notebook added to the repo
  • clean docstrings and comments have been written
  • if any issue/observation has been discovered, a new issue has been opened

Future improvements

n/a

@LisaCoiffard LisaCoiffard marked this pull request as draft February 12, 2024 17:05
@LisaCoiffard LisaCoiffard marked this pull request as ready for review February 12, 2024 17:32
Lookatator
Lookatator approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@Lookatator Lookatator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LisaCoiffard ! Thank you very much for this fix !

@Lookatator Lookatator merged commit eb2cf31 into adaptive-intelligent-robotics:main Feb 13, 2024
5 checks passed
@LisaCoiffard LisaCoiffard deleted the hotfix/types branch September 24, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lookatator Lookatator Lookatator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LisaCoiffard @Lookatator