Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility causing plp scroll to jump #1241

Closed
kirsty-hames opened this issue Sep 15, 2016 · 1 comment
Closed

Accessibility causing plp scroll to jump #1241

kirsty-hames opened this issue Sep 15, 2016 · 1 comment

Comments

@kirsty-hames
Copy link
Contributor

On navigating to a component using plp drawer, the top of the component is scrolled to and then jumps down the page.
kirsty-hames added a commit that referenced this issue Sep 15, 2016
@kirsty-hames
Remove additional px from topOffset variable
bd0320b 
Fix issue #1241 - a11y calculates component to be out of view from additional px added.
@kirsty-hames kirsty-hames mentioned this issue Sep 15, 2016
Merged
@moloko
Copy link
Contributor

moloko commented Sep 19, 2016

done in 51c83a7

@moloko moloko closed this as completed Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @kirsty-hames