Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hack in questionModel.js for v1-v2 buttons compatibility #1708

Closed
brian-learningpool opened this issue Aug 9, 2017 · 0 comments
Closed

Remove hack in questionModel.js for v1-v2 buttons compatibility #1708

brian-learningpool opened this issue Aug 9, 2017 · 0 comments
Milestone
Adapt v3

Comments

@brian-learningpool
Copy link
Member

The code here is only required to transition v1 courses to v2, so can probably be dropped for a v3 release:
https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/models/questionModel.js#L51-L92
@moloko moloko modified the milestone: v3.0.0 Aug 18, 2017
brian-learningpool added a commit that referenced this issue Aug 21, 2017
@brian-learningpool
Resolves #1708, removes v1 button hacks
a2790c2 
Removed the version 1->2 button hacks in preparation for the release of version 3.0.
@brian-learningpool brian-learningpool added this to the Adapt v3 milestone Jan 22, 2018
@brian-learningpool brian-learningpool mentioned this issue Jan 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Adapt v3
Development

No branches or pull requests
3 participants
@moloko @brian-learningpool @oliverfoster