Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If HTML formatting is included in titles, it is read out by the screen reader #2549

Closed
moloko opened this issue Oct 17, 2019 · 0 comments · Fixed by #2551
Closed

If HTML formatting is included in titles, it is read out by the screen reader #2549

moloko opened this issue Oct 17, 2019 · 0 comments · Fixed by #2551
Assignees

Comments

@moloko
Copy link
Contributor

moloko commented Oct 17, 2019

I think some/all of the instances of {{compile displayTitle}} in heading.hbs should be changed to {{{compile title}} instead.

What I'm not sure is whether it should be necessary to provide a 'fallback' in the case that title isn't defined - or assume that it always should be i.e. if it isn't it's an error on the part of the content author.

Correction: should be fixable by changing from double curly-braces to triple.

@moloko moloko self-assigned this Oct 17, 2019
moloko added a commit that referenced this issue Oct 17, 2019
moloko added a commit that referenced this issue Oct 18, 2019
oliverfoster pushed a commit to olivermartinfoster/adapt-contrib-core that referenced this issue Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant