Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve frozen columns performance #1744

Merged
merged 21 commits into from
Oct 7, 2019
Merged

Improve frozen columns performance #1744

merged 21 commits into from
Oct 7, 2019

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 commented Aug 27, 2019 •
edited
Loading

  • Fix windowing logic
  • Use position:sticky when available
  • Fall back to existing logic
  • Cleanup viewport/header width calculation logic
  • Revisit css classes for positioning elements
  • Remove extra divs

Addition PRs

nstepien
nstepien requested changes Sep 6, 2019
View reviewed changes
examples/scripts/example31-isScrolling.js Outdated Show resolved Hide resolved
packages/react-data-grid/src/Cell.tsx Show resolved Hide resolved
packages/react-data-grid/src/Cell.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/src/Grid.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/src/Header.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/src/__tests__/Header.spec.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/src/__tests__/Header.spec.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/src/utils/domUtils.tsx Outdated Show resolved Hide resolved
qili26
qili26 reviewed Sep 19, 2019
View reviewed changes
packages/react-data-grid/src/Cell.tsx Show resolved Hide resolved
packages/react-data-grid/src/Grid.tsx Outdated Show resolved Hide resolved
examples/scripts/example31-isScrolling.js Outdated Show resolved Hide resolved
packages/react-data-grid/src/utils/viewportUtils.ts Outdated Show resolved Hide resolved
packages/react-data-grid/src/utils/viewportUtils.ts Outdated Show resolved Hide resolved
@amanmahajan7 amanmahajan7 marked this pull request as ready for review September 24, 2019 19:59
nstepien
nstepien requested changes Sep 25, 2019
View reviewed changes
packages/react-data-grid/src/Canvas.tsx Show resolved Hide resolved
packages/react-data-grid/src/Cell.tsx Show resolved Hide resolved
packages/react-data-grid/src/HeaderCell.tsx Show resolved Hide resolved
packages/react-data-grid/src/HeaderRow.tsx Show resolved Hide resolved
packages/react-data-grid/src/Viewport.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/style/rdg-cell.less Outdated Show resolved Hide resolved
amanmahajan7 and others added 4 commits September 25, 2019 09:55
@amanmahajan7 @nstepien
Check -webkit-sticky
e1d9aa2 
Co-Authored-By: Nicolas Stepien <567105+MayhemYDG@users.noreply.github.com>
@amanmahajan7
Add a few comments
3bbd401 
Delete unused ref
@amanmahajan7
Fix tests
62b76ec
@amanmahajan7
Cleanup scroll state logic
a15a965
nstepien
nstepien reviewed Sep 26, 2019
View reviewed changes
packages/react-data-grid/src/Grid.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/src/Viewport.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/src/Viewport.tsx Outdated Show resolved Hide resolved
packages/react-data-grid/src/utils/viewportUtils.ts Outdated Show resolved Hide resolved
@nstepien nstepien changed the base branch from next to canary October 7, 2019 13:57
@nstepien nstepien merged commit 8ca25da into canary Oct 7, 2019
@nstepien nstepien deleted the am-improve-props branch October 18, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qili26 qili26 qili26 left review comments

@nstepien nstepien nstepien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanmahajan7 @nstepien @qili26